feat: new theme system #161

sxyazi · 2023-09-16T13:47:09Z

Yazi now supports rewriting most of the UI using Lua and fully utilizes existing layout components.

You only need to import it as a plugin in yazi.toml:

[plugins]
preload = [
  "~/.config/yazi/my-ui.lua"
]

and rewrite the parts you want, such as:

function Header:render(area)
	local line = ui.Line {
		ui.Span("Hello, world!"):fg("red"),
		ui.Span("Hello, world!"):fg("green"),
	}

	return {
		ui.Paragraph(area, { line }),
	}
end

Then we have:

The new theme system documentation is currently in progress. For now, you can refer to the preset components at https://github.com/sxyazi/yazi/tree/main/plugin/preset/components

TODOs:

Features:

Progress
Highlighting
Short path

Issues:

The PR is bigger than anticipated and has taken more time.

There are still some unfinished works, additional PRs will be implemented shortly to prevent this one from continuing to expand.

Brixy · 2023-09-21T07:44:33Z

Thanks a lot for this excellent file manager! I use it on a daily basis.

I have played a bit with the current theming options and would like to suggest options to style

executable files,
symbolic links, and
empty files (or maybe different colors for different file sizes, including 0 byte).

Maybe this can be (or already is?) considered in your new theme system. Thank you very much!

sxyazi · 2023-09-21T15:20:37Z

Thanks for the suggestions; this is something I've been planning to do all along, but it might not be included in this big PR but rather in the smaller one that follows, as part of a progressive enhancement.

Brixy · 2023-09-21T19:44:04Z

Excellent. Not only is your file manager of top quality, but also very well maintained! Thanks a lot for this.

magnetophon · 2023-09-30T14:36:17Z

Excellent. Not only is your file manager of top quality, but also very well maintained! Thanks a lot for this.

I just wanted to repeat this! ❤

magnetophon · 2023-09-30T16:32:50Z

Not sure it it's ready for testing, but I just tried this branch, and got a crash:

  store                   │  0a9kdk3ialqxd8ckcb4764p2x3bzpdl1-jq-1.6-man             │  share thread 'main' panicked at 'cannot create a Lua reference, out of auxiliary stack space (used 1000197 slots)', /build/cargo-vendor-dir/mlua-0.9.1/src/lua.rs:3557:133bd7x0bs-kauth-5.110.0-dev      │
                            │  0bfh848j3il4zkdf7an9lqiinote: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
                            │  0bh9girfsnxryz6s9snmrl2pka4vs40h-nghttp2-1.51.0         │                                            fish: Job 1, 'nix run' terminated by signal SIGABRT (Abort)
                            │  0bw18xfl5x1f3w6v1b65zwarvcm7c7y7-hdf5-1.14.2            │                                                                                                       ⏎            
    ~/source/yazi   pr-9712724b !1 ───────────────────────────────────────────────────────────────────────────────────────────────────────────────── ✘ ABRT   39m 39s   1.69.0-nightly  18:28:04
❮ jhhh
                            │  0cc31xc2rdafrb45bf7895hb8y75xan6-alsa-lib-1.2.9-dev     │

I was browsing my nix store, which is huge.
I just copied the output as it appeared on my terminal, some of this is fro my prompt, some of it from the yazi gui, some of it from the error.

I also noticed it was much slower than other versions of yazi, at least in this huge dir.

sxyazi · 2023-10-03T09:27:18Z

Hey @magnetophon, I've pushed a new optimized version, and it should work. Thanks for your interest in this ongoing feature.

magnetophon · 2023-10-05T06:27:26Z

Hey @magnetophon, I've pushed a new optimized version, and it should work. Thanks for your interest in this ongoing feature.

Now it's blazing fast again, with no crashes.
Thank you!

sxyazi · 2023-10-11T16:44:43Z

I have played a bit with the current theming options and would like to suggest options to style

@Brixy Hi, this PR is completed. I have some time to work on it next. Would you like to file an issue for that?

sxyazi mentioned this pull request Sep 19, 2023

[Feature Request] Custom Preview Commands #182

Closed

sxyazi force-pushed the pr-9712724b branch from 37de10e to db8dd43 Compare September 19, 2023 01:24

sxyazi mentioned this pull request Sep 21, 2023

What does the "99% 1 left" mean? #110

Closed

sxyazi force-pushed the pr-9712724b branch 2 times, most recently from d6541a9 to 784a1c6 Compare September 22, 2023 04:53

sxyazi mentioned this pull request Sep 26, 2023

Toggle for more file info #220

Closed

Eric-Song-Nop mentioned this pull request Sep 26, 2023

fix: collect and fix all hard coded themes and color #221

Merged

8 tasks

sxyazi force-pushed the pr-9712724b branch 2 times, most recently from 2b93ed0 to 167b44b Compare September 27, 2023 03:08

sxyazi force-pushed the pr-9712724b branch from 86d8e1f to 77e1005 Compare October 3, 2023 09:26

sxyazi force-pushed the main branch from ddd2417 to 77988d4 Compare October 4, 2023 06:08

sxyazi force-pushed the pr-9712724b branch from 6a58b4d to 61c633e Compare October 5, 2023 10:21

This was referenced Oct 6, 2023

remove operation don't complete #246

Closed

Feature requests #51

Open

sxyazi force-pushed the pr-9712724b branch 2 times, most recently from 19f3e1f to 14c194c Compare October 11, 2023 11:00

sxyazi added 7 commits October 11, 2023 22:40

feat: better theme system

9ff11b2

..

befcd55

..

03b1e87

..

528e4a6

..

fa2a9ce

..

d703e00

..

a9074c1

sxyazi added 13 commits October 11, 2023 22:42

..

f3b8227

..

2616419

..

2c2e166

..

e6a4c0e

..

a3971fc

..

46c54f6

..

4718c4d

..

8cb91f3

.. [no ci]

5d1591f

..

71c86a5

..

e2dfa98

..

ebe6714

..

35f4c73

sxyazi force-pushed the pr-9712724b branch from 14c194c to 35f4c73 Compare October 11, 2023 16:02

sxyazi changed the title ~~[WIP] feat: better theme system~~ feat: new theme system Oct 11, 2023

sxyazi merged commit 1a2798e into main Oct 11, 2023

sxyazi deleted the pr-9712724b branch October 11, 2023 16:09

This was referenced Oct 12, 2023

Add visible key to show wether currently hovered file is selected with relative width of left column set to 0 #217

Closed

Support color coding executables, symbolic links, and empty files #262

Closed

branchvincent mentioned this pull request Oct 21, 2023

yazi 0.1.5 Homebrew/homebrew-core#152006

Merged

github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new theme system #161

feat: new theme system #161

sxyazi commented Sep 16, 2023 •

edited

Loading

Brixy commented Sep 21, 2023

sxyazi commented Sep 21, 2023

Brixy commented Sep 21, 2023

magnetophon commented Sep 30, 2023

magnetophon commented Sep 30, 2023 •

edited

Loading

sxyazi commented Oct 3, 2023 •

edited

Loading

magnetophon commented Oct 5, 2023

sxyazi commented Oct 11, 2023

feat: new theme system #161

feat: new theme system #161

Conversation

sxyazi commented Sep 16, 2023 • edited Loading

TODOs:

Brixy commented Sep 21, 2023

sxyazi commented Sep 21, 2023

Brixy commented Sep 21, 2023

magnetophon commented Sep 30, 2023

magnetophon commented Sep 30, 2023 • edited Loading

sxyazi commented Oct 3, 2023 • edited Loading

magnetophon commented Oct 5, 2023

sxyazi commented Oct 11, 2023

sxyazi commented Sep 16, 2023 •

edited

Loading

magnetophon commented Sep 30, 2023 •

edited

Loading

sxyazi commented Oct 3, 2023 •

edited

Loading